Add .size and .error_call to vec_interleave()
#2058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support #2059, but I think these are the correct way to round out this function anyways.
Also now goes through an internal
list_interleave(), which is a convenient form when you already have a list that also exposes anx_argfor improved error messaging.Also fixes an issue where
vec_interleave(1:2, NULL, 1:3)was reporting the wrong index in the error message due to compacting out theNULLtoo early. Sincelist_combine()itself can handleNULLs and elegantly drops them at the right time, we now just pass through to that with an emptyinteger()location index.