Partial test fix for ggplot2 4.0.0 changges #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following warning raised when running tests: Warning (test-expect-doppelganger.R:32:5): no 'svglite supports one page' error (r-lib#85) The `size` argument of `element_line()` is deprecated as of ggplot2 3.4.0. ℹ Please use the `linewidth` argument instead.
This is due to changes to geom_histogram() occurred in ggplot2 4.0.0 (tidyverse/ggplot2#5891). By setting the `bins` argument we avoid this message being printed: `stat_bin()` using `bins = 30`. Pick better value `binwidth`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a warning and one of the two failing tests, the latter by accepting the new snapshot. Details are in the single commit messages.
Unfortunately I couldn't figure out the second failure, it may have to do with changes to
theme().