Add Skills, Reputation, and Quests pages#42
Add Skills, Reputation, and Quests pages#42smthbh wants to merge 59 commits intor-o-b-o-t-o:masterfrom
Conversation
…pdates Bumps the npm_and_yarn group with 7 updates in the / directory: | Package | From | To | | --- | --- | --- | | [express](https://github.com/expressjs/express) | `4.18.1` | `4.20.0` | | [mysql2](https://github.com/sidorares/node-mysql2) | `2.3.3` | `3.9.8` | | [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) | `0.2.0` | `0.2.2` | | [got](https://github.com/sindresorhus/got) | `9.6.0` | `removed` | | [nodemon](https://github.com/remy/nodemon) | `2.0.18` | `2.0.22` | | [moment](https://github.com/moment/moment) | `2.29.2` | `2.30.1` | | [send](https://github.com/pillarjs/send) | `0.18.0` | `0.19.0` | | [express](https://github.com/expressjs/express) | `4.20.0` | `4.21.2` | Updates `express` from 4.18.1 to 4.20.0 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.1...4.20.0) Updates `mysql2` from 2.3.3 to 3.9.8 - [Release notes](https://github.com/sidorares/node-mysql2/releases) - [Changelog](https://github.com/sidorares/node-mysql2/blob/master/Changelog.md) - [Commits](sidorares/node-mysql2@v2.3.3...v3.9.8) Updates `body-parser` from 1.20.0 to 1.20.3 - [Release notes](https://github.com/expressjs/body-parser/releases) - [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md) - [Commits](expressjs/body-parser@1.20.0...1.20.3) Updates `cookie` from 0.5.0 to 0.6.0 - [Release notes](https://github.com/jshttp/cookie/releases) - [Changelog](https://github.com/jshttp/cookie/blob/v0.6.0/HISTORY.md) - [Commits](jshttp/cookie@v0.5.0...v0.6.0) Updates `decode-uri-component` from 0.2.0 to 0.2.2 - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2) Removes `got` Updates `nodemon` from 2.0.18 to 2.0.22 - [Release notes](https://github.com/remy/nodemon/releases) - [Commits](remy/nodemon@v2.0.18...v2.0.22) Updates `moment` from 2.29.2 to 2.30.1 - [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md) - [Commits](moment/moment@2.29.2...2.30.1) Updates `path-to-regexp` from 0.1.7 to 0.1.10 - [Release notes](https://github.com/pillarjs/path-to-regexp/releases) - [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md) - [Commits](pillarjs/path-to-regexp@v0.1.7...v0.1.10) Updates `send` from 0.18.0 to 0.19.0 - [Release notes](https://github.com/pillarjs/send/releases) - [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md) - [Commits](pillarjs/send@0.18.0...0.19.0) Updates `express` from 4.20.0 to 4.21.2 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.1...4.20.0) Updates `serve-static` from 1.15.0 to 1.16.2 - [Release notes](https://github.com/expressjs/serve-static/releases) - [Changelog](https://github.com/expressjs/serve-static/blob/v1.16.2/HISTORY.md) - [Commits](expressjs/serve-static@v1.15.0...v1.16.2) --- updated-dependencies: - dependency-name: express dependency-version: 4.20.0 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: mysql2 dependency-version: 3.9.8 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: body-parser dependency-version: 1.20.3 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: cookie dependency-version: 0.6.0 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: decode-uri-component dependency-version: 0.2.2 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: got dependency-version: dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: nodemon dependency-version: 2.0.22 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: moment dependency-version: 2.30.1 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: path-to-regexp dependency-version: 0.1.10 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: send dependency-version: 0.19.0 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: express dependency-version: 4.21.2 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: serve-static dependency-version: 1.16.2 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
…n-1eaf09dcb9 build(deps): bump the npm_and_yarn group across 1 directory with 11 updates
Add class and race text
Add skills page
add better graphics for skills page
remove unneeded header
Update skills graphics
Quests page
Update quest compare usability
add favicons
add zone link to character header
Add feature flags
…h/azerothcore-armory into smthbh-merge-master-branch
|
@smthbh the implementation used from wowhead was only related to |
My users preferred wowhead; there's more comments and replies on quests which makes it more helpful for figuring out how to do a quest if you're unsure or stuck. |
|
I'm uncertain if that's a deal breaker or not for roboto, if wowhead was added a functionality to the armory I would probably suggest to all the armory not just to what's being added here, but with the criaviact that default links are they are now, go to aowow (the reason because is the same data set as the ac server) and wowhead link could be if you hold a modifier e.g Left ALT + Click to open wowhead |
|
Would it be possible to make use of |
Yup that's certainly possible, currently it's built to mirror how it displays in game. |
Yeah, I mean you're right, it is simpler to only use aowow for links, unfortunately aowow is not nearly as popular as wowhead, which means it's much more useful to use wowhead for quest links. Two sources for links adds complexity, but IMO the added benefit of the site's popularity and multitude of helpful comments about quests on wowhead makes it worth it. It would suck to click on quest links which take you to aowow, and then still have to google the quest and navigate to wowhead to get help. |
|
Is why I suggested both being in cooperated, having a modifier key that uses the wowhead link but normal click would be the aowow, the advantage of aowow is that shows you the core information unlike wowhead, wowhead is great for comments and images |
|
Isn't the point of it being an environment variable like that that it can be configured? I.e. you can change the AoWoW link to Wowhead as a user. |
|
@heyitsbench I haven't looked into whether wowhead could replace everything that is being done with aowow, I know there's a lot being done with it. |
|
The way I see it (and Roboto may disagree with me), ideally that variable would just be treated as a config option by a user installing the armory, and the armory could support that variable being set to AoWoW and/or its derivates or Wowhead for most/all uses of that API, and not use the two simultaneously. Again, I might be wrong here, but that's my interpretation. |
4 participants
This PR adds Skills, Reputation, and Quests pages to the Armory.
It also adds favicons, character zone locations, and feature flags to be able to disable the pages above.
It also adds wowhead links for zones and quests (that's what my users requested)
The quests and quest comparison tool is very useful for private PvE servers, but could probably be used for griefing on PvP servers, hence the feature flags.
The skills and quests pages work great, but the reputation doesn't seem to be 100% accurate for every race and faction; because of this, I made sure there is an option to disable it with a feature flag.
The readme and example configs have been updated to reflect the new options and pages.