fix(character): handle undefined characterModelTransmogs array#45
Open
kamikyforce wants to merge 3 commits intor-o-b-o-t-o:masterfrom
Open
fix(character): handle undefined characterModelTransmogs array#45kamikyforce wants to merge 3 commits intor-o-b-o-t-o:masterfrom
kamikyforce wants to merge 3 commits intor-o-b-o-t-o:masterfrom
Conversation
added 3 commits
December 7, 2025 08:05
Add checks for Array.isArray(charData.characterModelTransmogs) to prevent errors when the array is undefined
Add checks for Array.isArray(charData.characterModelTransmogs) to prevent errors when the array is undefined
Refine gitignore rules for data directory to explicitly ignore all generated assets while keeping specific tracked files like background image and CSVs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
charData.characterModelTransmogsis undefined.Changes
Array.isArray(charData.characterModelTransmogs)before reading or iterating:itemswith a safe fallback tocharData.characterModelItems.setSlotVisibledecides whether to use transmogs only when the array exists.characterModel.itemswith a safe fallback:(charData.characterModelTransmogs ?? charData.characterModelItems)so models render even without transmogs.characterModelTransmogsexists and there are items with atransmog.Code References
static/character.hbs:166–170static/character.hbs:197–201static/character.hbs:153–165static/character.hbs:425–426Behavior
Testing
ACORE_ARMORY_TRANSMOG_MODULE=0) or use a character without transmogs:Notes
static/character.hbsis changed in this branch. No other files or data assets are included.