Conversation
AlexD10S
left a comment
AlexD10S
left a comment
There was a problem hiding this comment.
Tested and it works perfectly!
However, before merging, there’s one important point to consider:
In previous versions, we didn’t have a network.toml file, it was generated by pop-cli when creating a new template.
If we merge this as is, pop-cli will likely overwrite the existing network.toml when it generates the template (see: https://github.com/r0gue-io/pop-cli/blob/main/crates/pop-chains/src/new_chain.rs#L77).
I see two possible approaches to handle this, I’ll let you decide which one you prefer:
1- Keep network.toml here and remove these two lines in pop-cli https://github.com/r0gue-io/pop-cli/blob/main/crates/pop-chains/src/new_chain.rs#L77 for versions > 2506 in the templates.
2- Remove network.toml from here and update the pop-cli template to use this format for versions > 2506 in the network.templ https://github.com/r0gue-io/pop-cli/blob/main/crates/pop-chains/templates/base/network.templ
|
I prefer option 1 🤔. The template in its source should embrace pop. |
|
@AlexD10S @al3mart @Daanvdplas can we progress with this PR? After r0gue-io/pop-cli#711 being merged there are no more blockers. |
AlexD10S
left a comment
AlexD10S
left a comment
There was a problem hiding this comment.
Thanks! after the changes requested in pop-cli it looks good to me to merge this one
| pop build spec \ | ||
| --profile release \ | ||
| --id 2000 \ | ||
| --type local \ | ||
| --relay paseo-local \ | ||
| --protocol-id custom \ | ||
| --chain local_testnet \ | ||
| --default-bootnode=false \ | ||
| --genesis-code=false \ | ||
| --genesis-state=false \ | ||
| --deterministic=false \ | ||
| --output ./target/release/chain-spec.json |
4 participants
This is the same PR previously reverted. With pop v0.11.0 the original issue that prevented the PR to be merged no longer exists and hence we can incorporate the changes.