Skip to content

feat: remove network configuration from base-parachain #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moliholy merged 2 commits into from
Nov 6, 2025
Merged

feat: remove network configuration from base-parachain #711

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7386dec
feat: conditionally remove network configuration from base-parachain
moliholy Nov 5, 2025
5bbe283
Merge branch 'main' into feat/remove-base-parachain-network-config
moliholy Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions crates/pop-chains/src/new_chain.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ use pop_common::{
use std::{fs, path::Path};
use walkdir::WalkDir;

// The latest version where we should overwrite the ./network.toml file on.
const LATEST_NETWORK_TOML_OVERWRITE_VERSION: &str = "polkadot-stable2506";

/// Create a new chain.
///
/// # Arguments
Expand Down Expand Up @@ -48,7 +51,7 @@ pub fn instantiate_standard_template(
let temp_dir = ::tempfile::TempDir::new_in(std::env::temp_dir())?;
let source = temp_dir.path();

let tag = Git::clone_and_degit(template.repository_url()?, source, tag_version)?;
let tag = Git::clone_and_degit(template.repository_url()?, source, tag_version.clone())?;

for entry in WalkDir::new(source) {
let entry = entry?;
Expand All @@ -73,9 +76,16 @@ pub fn instantiate_standard_template(
&target.join("node/src/chain_spec.rs"),
chainspec.render().expect("infallible").as_ref(),
)?;
// Add network configuration
let network = Network { node: "parachain-template-node".into() };
write_to_file(&target.join("network.toml"), network.render().expect("infallible").as_ref())?;
if let Some(version) = tag_version.as_deref() &&
version <= LATEST_NETWORK_TOML_OVERWRITE_VERSION
{
// Add network configuration
let network = Network { node: "parachain-template-node".into() };
write_to_file(
&target.join("network.toml"),
network.render().expect("infallible").as_ref(),
)?;
}
Ok(tag)
}

Expand Down Expand Up @@ -106,7 +116,12 @@ mod tests {
decimals: 18,
initial_endowment: "1000000".to_string(),
};
instantiate_standard_template(&ChainTemplate::Standard, temp_dir.path(), config, None)?;
instantiate_standard_template(
&ChainTemplate::Standard,
temp_dir.path(),
config,
Some(LATEST_NETWORK_TOML_OVERWRITE_VERSION.to_string()),
)?;
Ok(temp_dir)
}

Expand Down
Loading