Skip to content

fix: actually use already passed contract message arguments#713

Closed
moliholy wants to merge 1 commit intomainfrom
fix/contract-function-args
Closed

fix: actually use already passed contract message arguments#713
moliholy wants to merge 1 commit intomainfrom
fix/contract-function-args

Conversation

@moliholy
Copy link
Collaborator

@moliholy moliholy commented Nov 4, 2025

This PR fixes an issue by which passed arguments when calling a contract were omitted.

@moliholy moliholy self-assigned this Nov 4, 2025
@moliholy moliholy force-pushed the fix/contract-function-args branch from 9a9c250 to e300fa9 Compare November 4, 2025 16:49
@Daanvdplas
Copy link
Collaborator

#712

@moliholy
Copy link
Collaborator Author

moliholy commented Nov 4, 2025

Closes in favor of #712.

@moliholy moliholy closed this Nov 4, 2025
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.92%. Comparing base (1a0d204) to head (e300fa9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/call/contract.rs 0.00% 0 Missing and 1 partial ⚠️
crates/pop-cli/src/commands/up/contract.rs 0.00% 1 Missing ⚠️
crates/pop-cli/src/common/contracts.rs 80.00% 0 Missing and 1 partial ⚠️
@@           Coverage Diff           @@
##             main     #713   +/-   ##
=======================================
  Coverage   76.92%   76.92%           
=======================================
  Files         111      111           
  Lines       25234    25235    +1     
  Branches    25234    25235    +1     
=======================================
+ Hits        19412    19413    +1     
  Misses       3763     3763           
  Partials     2059     2059           
Files with missing lines Coverage Δ
crates/pop-cli/src/commands/call/contract.rs 69.43% <0.00%> (ø)
crates/pop-cli/src/commands/up/contract.rs 13.97% <0.00%> (ø)
crates/pop-cli/src/common/contracts.rs 71.56% <80.00%> (+0.14%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants