Optionally set icon in WinForms #1755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Fair enough, thanks for the contribution |
This was referenced Dec 5, 2025
github-merge-queue bot
pushed a commit
to zauberzeug/nicegui
that referenced
this pull request
Dec 8, 2025
### Motivation There are new [releases](https://github.com/r0x0r/pywebview/releases) for `pywebview` with nice improvements and AFAIK no breaking interfaces to NiceGUI. Particularly looking forward to the next release including r0x0r/pywebview#1755, which resolves the issue about the icon not showing on Windows discussed here: #1745 (reply in thread) ### Implementation Trivial change in `pyproject.toml`. **Note:** Changing the constraint to `>=6.0,<7` might address this comment: [pyproject.toml#L146](https://github.com/zauberzeug/nicegui/blob/97c6b1e/pyproject.toml#L146) ### Progress - [x] I chose a meaningful title that completes the sentence: "If applied, this PR will..." - [x] The implementation is complete. - [x] Pytests have been added (or are not necessary). - [x] Documentation has been added (or is not necessary). --------- Co-authored-by: Paco Sevilla <[email protected]> Co-authored-by: Falko Schindler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to set an icon using
webview.start(icon=<file_path>)when the platform is WinForms (i.e. default on Windows).This is implemented in a similar fashion as for the Qt and GTK, with the difference that we check whether
_state['icon']exists (and is a file).This makes sure that the icon set when freezing an app can be used without having to bundle its file.
I hope this addresses the concerns raised in #1665 and #1411.
Background/Rationale: At the company where I work, we don't freeze our (internal) apps, but we deploy them to a Python Registry and install them with
uv tools install. This allows us to deploy a single (pure-Python) package for both Windows and Linux users.Even for people that freeze their apps, I think it would be nice if they could show the icon during development (on Windows).