Open
Conversation
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
| try: | ||
| SEMGREP_APP_TOKEN = os.getenv("SEMGREP_APP_TOKEN") | ||
| except KeyError: | ||
| print("Please set the environment variable SEMGREP_APP_TOKEN") |
There was a problem hiding this comment.
Semgrep found a match
Suggested change
| print("Please set the environment variable SEMGREP_APP_TOKEN") | |
| logging.info("Please set the environment variable SEMGREP_APP_TOKEN") |
| print(project_name) | ||
| tags = project['tags'] | ||
| for tag in tags: | ||
| print(tag) |
There was a problem hiding this comment.
Semgrep found a match
Suggested change
| print(tag) | |
| logging.info(tag) |
| for project in data['projects']: | ||
| project_name = project['name'] | ||
| print("************") | ||
| print(project_name) |
There was a problem hiding this comment.
Semgrep found a match
Suggested change
| print(project_name) | |
| logging.info(project_name) |
| data = json.loads(r.text) | ||
| for project in data['projects']: | ||
| project_name = project['name'] | ||
| print("************") |
There was a problem hiding this comment.
Semgrep found a match
Suggested change
| print("************") | |
| logging.info("************") |
| sys.exit(f'Get failed: {r.text}') | ||
| data = json.loads(r.text) | ||
| slug_name = data['deployments'][0].get('slug') | ||
| print("Accessing org: " + slug_name) |
There was a problem hiding this comment.
Semgrep found a match
Suggested change
| print("Accessing org: " + slug_name) | |
| logging.info(("Accessing org: " + slug_name)) |
Contributor
Author
|
@pjzcodes could you review this PR and approve if you agree? |
armchairlinguist
approved these changes
Mar 21, 2024
Contributor
armchairlinguist
left a comment
armchairlinguist
left a comment
There was a problem hiding this comment.
This looks fine to me, but I don't really understand why it's a separate file. We already have two instances of scripts that fetch projects under API utilities; it would make more sense to me to add this functionality to one of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.