fix: Ensure consistent task finalization for queued tasks (TaskError and TaskProcessed events)

src/Tasks/Middleware/FinalizeTaskMiddleware.php

@@ -10,8 +10,8 @@ final class FinalizeTaskMiddleware
 {
     public function handle(Task $task, callable $next): void
     {
-        $next($task);
-
         $task->finalize();
+
+        $next($task);
     }
 }

tests/Feature/TaskTest.php

@@ -14,6 +14,7 @@
 use Illuminate\Support\Carbon;
 use Illuminate\Support\Facades\Bus;
 use Illuminate\Support\Facades\Event;
+use Illuminate\Contracts\Queue\ShouldQueue;
 
 function getJobFromReflection(PendingDispatch $task): object
 {
@@ -450,7 +451,6 @@ public function handle(): self
 
     $middleware = new FinalizeTaskMiddleware;
 
-    // Call middleware with a next that simply returns the task
     $middleware->handle($task, fn ($t) => $t);
 
     Event::assertDispatched(Processed::class);
@@ -479,3 +479,26 @@ class ProcessWithFinalize extends Brain\Process
 
     Event::assertDispatched(Processed::class);
 });
+
+it('queued tasks are finalized before going through next middleware', function (): void {
+    Event::fake();
+
+    class QueuedTask extends Task implements ShouldQueue
+    {
+        public function handle(): self
+        {
+            return $this;
+        }
+    }
+
+    class ProcessQueuedTask extends Brain\Process
+    {
+        protected array $tasks = [
+            QueuedTask::class,
+        ];
+    }
+
+    ProcessQueuedTask::dispatchSync();
+
+    Event::assertDispatched(Processed::class);
+});