Merged
Conversation
The minizinc Python library deprecated the 'timeout' parameter in favor of 'time_limit'. This fix changes the solve_async call to use the correct parameter name, ensuring timeouts work as expected. Changes: - Updated main.py to use time_limit instead of timeout parameter - Added comprehensive timeout test that verifies timeout actually interrupts long-running computations (14-queens problem with all_solutions) - Test verifies solver stops around timeout duration and returns partial results The new test uses a 14-queens problem (365,596 total solutions) with a 2-second timeout and verifies: 1. Solver stops within expected time range (1.5-5 seconds) 2. Partial solutions are returned (not all 365k solutions) 3. Status indicates incomplete solving (SATISFIED, not ALL_SOLUTIONS)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minizinc Python library deprecated the 'timeout' parameter in favor of 'time_limit'. This fix changes the solve_async call to use the correct parameter name, ensuring timeouts work as expected.
Changes:
The new test uses a 14-queens problem (365,596 total solutions) with a 2-second timeout and verifies: