bootstrap: Do not needlessly podman pull

When the release image is already present, the script should not try
pulling. This slows down bootstrapping as well as breaking image
pre-caching.

Signed-off-by: Antoni Segura Puimedon <[email protected]>

Author: celebdor

data/data/bootstrap/files/usr/local/bin/release-image-download.sh.template

@@ -13,22 +13,27 @@ set -euo pipefail
 
 RELEASE_IMAGE={{.ReleaseImage}}
 
-echo "Pulling $RELEASE_IMAGE..."
 release_image_issue="/etc/issue.d/50_release-image.issue"
-while true
-do
+if podman image exists "$RELEASE_IMAGE"; then
     record_service_stage_start "pull-release-image"
-    if podman pull --quiet "$RELEASE_IMAGE"
-    then
-        rm -f "${release_image_issue}"
-        record_service_stage_success
-        break
-    else
-        printf '\n\\e{lightred}Unable to pull OpenShift release image\\e{reset}\n' >"${release_image_issue}"
-        record_service_stage_failure
-        echo "Pull failed. Retrying $RELEASE_IMAGE..."
-    fi
-done
+    record_service_stage_success
+else
+    echo "Pulling $RELEASE_IMAGE..."
+    while true
+    do
+        record_service_stage_start "pull-release-image"
+        if podman pull --quiet "$RELEASE_IMAGE"
+        then
+            rm -f "${release_image_issue}"
+            record_service_stage_success
+            break
+        else
+            printf '\n\\e{lightred}Unable to pull OpenShift release image\\e{reset}\n' >"${release_image_issue}"
+            record_service_stage_failure
+            echo "Pull failed. Retrying $RELEASE_IMAGE..."
+        fi
+    done
+fi
 
 # Sanity check the image metadata to see if the arches match
 record_service_stage_start "image-metadata-arches-match"