Added Plugin for Odysee Timestamps and compatibility with Firefox#392
Open
andreas-fahrecker wants to merge 1 commit intorNeomy:masterfrom
Open
Added Plugin for Odysee Timestamps and compatibility with Firefox#392andreas-fahrecker wants to merge 1 commit intorNeomy:masterfrom
andreas-fahrecker wants to merge 1 commit intorNeomy:masterfrom
Conversation
- I added the new Odysee timestamp plugin with the options button translations for english and german. - I also noticed that the Extension hasn't gotten a updated on firefox since version 0.6.7 and noticed that the current version isn't compatible with firefox anymore, so I fixed the manifest.json for firefox compatibility and stated using chrome.runtime.getManifest() instead of chrome.app.getDetails() because app.getDetails is deprecated by firefox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Issue #390 I added the new Odysee timestamp plugin with the options button translations for english and german.
While working on that new plugin, I noticed that the Extension hasn't gotten a updated on Firefox since version 0.6.7 and noticed that the current version isn't compatible with Firefox anymore. (background.service_worker is not supported (see Firefox bug 1573659).
So I fixed the manifest.json for Firefox compatibility and stated using chrome.runtime.getManifest() instead of chrome.app.getDetails() because app.getDetails() is deprecated by Firefox and runtime.getManifest() also allows accessing content_scripts from the manifest and is not deprecated.
So Issue #371 should also be addressed if it will get uploaded to the Firefox extension store