Merged
Conversation
Member
|
Thanks, good work. If you want you can add yourself as a package contributor in the DESCRIPTION file. Could you use the v4.1 branch version as basis for that and change the target branch from master to v4.1 at the same time? |
…ia_gonc * upstream/v4.1: (50 commits) Add docs for eurostat_geodata_60_2024 Add geodata for 2024 Fix class of args Keep default nuts_level Harmonise params with giscoR Add 2024 as a valid NUTS release year to Rd Add 2024 as a valid NUTS release year Dev version 4.1.0.9006: Remove experimental functions, fix tests Remove RefManageR dependency, minor version bump SDMX metadata functions, version bump Remove httr from imports Update docs Move lifecycle from imports to suggests as recommended by lifecycle docs: Tests for get_eurostat_sdmx Declare imports Declare functions as experimental Update CITATION to new template Use na.rm in data.table::melt Update year Re-render README ...
Member
|
I could also update the pkg in CRAN. @pitkant maybe you can ping me when all is ready for that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, a eurostat code is not available anymore, breaking examples and tests. This PR aims to update the code from avia_gonc (National freight and mail air transport by reporting country) to avia_gooc (Freight and mail air transport by type of schedule, transport coverage and country). This will fix 2 failures and 6 warnings.