Fix TOC offset reporting #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ZuluIDE repo, the issue ZuluIDE/ZuluIDE-firmware#179 Shows Alcohol 120% reporting different LBA offsets than the bin/cue it mounts from the ZuluIDE. That particular bin/cue had both PREGAP and INDEX 0 directives. The PREGAP offset wasn't carrying over the LBA offset to the next tracks. Using an accumulator for PREGAP offset and adding it to data_start and track_start fixes the issue. And hopefully subtracting it from the file offset will fix the issue. The reporting side works in Alcohol 120%, have not tested if the data/audio side works yet.
Propagates the pregap offset for correct LBA locations defined as MSF values in the CUE file. This fixes tests - Test TRACK 03 (audio with index 0) - Test TRACK 11 (audio from wav)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ZuluIDE repo, the issue ZuluIDE/ZuluIDE-firmware#179
Shows Alcohol 120% reporting different LBA offsets than the bin/cue
it mounts from the ZuluIDE. That particular bin/cue had both PREGAP
and INDEX 0 directives. The PREGAP offset wasn't carrying over the LBA
offset to the next tracks.
Using an accumulator for PREGAP offset and adding it to data_start
and track_start fixes the issue.
Added pregap offset adjustment to
test/CUEParser_test.cpp