Skip to content

Remove zeroed sockets_used/sockets_total #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Remove zeroed sockets_used/sockets_total #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8015fc
Remove zeroed sockets_used/sockets_total
lhoguin Jun 24, 2024
396e95f
Remove a getter and a setter related to the now removed field
michaelklishin Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions src/main/java/com/rabbitmq/http/client/domain/NodeInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,6 @@ public class NodeInfo {
@JsonProperty("fd_used_details")
private RateDetails fdUsedDetails;

@JsonProperty("sockets_used")
private long socketsUsed;
@JsonProperty("sockets_total")
private long socketsTotal;
@JsonProperty("sockets_used_details")
private RateDetails socketsUsedDetails;

@JsonProperty("mem_used")
private long memoryUsed;
@JsonProperty("mem_limit")
Expand Down Expand Up @@ -174,22 +167,6 @@ public void setFileDescriptorsTotal(long fileDescriptorsTotal) {
this.fileDescriptorsTotal = fileDescriptorsTotal;
}

public long getSocketsUsed() {
return socketsUsed;
}

public void setSocketsUsed(long socketsUsed) {
this.socketsUsed = socketsUsed;
}

public long getSocketsTotal() {
return socketsTotal;
}

public void setSocketsTotal(long socketsTotal) {
this.socketsTotal = socketsTotal;
}

public long getMemoryUsed() {
return memoryUsed;
}
Expand Down Expand Up @@ -442,14 +419,6 @@ public void setErlangProcessesUsedDetails(RateDetails erlangProcessesUsedDetails
this.erlangProcessesUsedDetails = erlangProcessesUsedDetails;
}

public RateDetails getSocketsUsedDetails() {
return socketsUsedDetails;
}

public void setSocketsUsedDetails(RateDetails socketsUsedDetails) {
this.socketsUsedDetails = socketsUsedDetails;
}

public String getRatesMode() {
return ratesMode;
}
Expand Down Expand Up @@ -483,9 +452,6 @@ public String toString() {
", fileDescriptorsUsed=" + fileDescriptorsUsed +
", fileDescriptorsTotal=" + fileDescriptorsTotal +
", fdUsedDetails=" + fdUsedDetails +
", socketsUsed=" + socketsUsed +
", socketsTotal=" + socketsTotal +
", socketsUsedDetails=" + socketsUsedDetails +
", memoryUsed=" + memoryUsed +
", memoryLimit=" + memoryLimit +
", memoryAlarmActive=" + memoryAlarmActive +
Expand Down
1 change: 0 additions & 1 deletion src/test/groovy/com/rabbitmq/http/client/ClientSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3075,7 +3075,6 @@ class ClientSpec extends Specification {
protected static void verifyNode(NodeInfo node) {
assert node != null
assert node.name != null
assert node.socketsUsed <= node.socketsTotal
assert node.erlangProcessesUsed <= node.erlangProcessesTotal
assert node.erlangRunQueueLength >= 0
assert node.memoryUsed <= node.memoryLimit
Expand Down
1 change: 0 additions & 1 deletion src/test/groovy/com/rabbitmq/http/client/ReactorNettyClientSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2632,7 +2632,6 @@ class ReactorNettyClientSpec extends Specification {
protected static void verifyNode(NodeInfo node) {
assert node != null
assert node.name != null
assert node.socketsUsed <= node.socketsTotal
assert node.erlangProcessesUsed <= node.erlangProcessesTotal
assert node.erlangRunQueueLength >= 0
assert node.memoryUsed <= node.memoryLimit
Expand Down