Skip to content

khepri_tree: Ignore keep_while conditions on children on node creation #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: v0.17.x
Choose a base branch
from
Draft

khepri_tree: Ignore keep_while conditions on children on node creation #351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions src/khepri_tree.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,11 +655,13 @@ insert_or_update_node(
Path, Node, Payload, TreeOptions, Result),
case Ret of
{ok, Node1, Result1} when Result1 =/= #{} ->
AbsKeepWhile = to_absolute_keep_while(
Path, KeepWhile),
KeepWhileOnOthers = maps:remove(Path, AbsKeepWhile),
AbsKeepWhile0 = to_absolute_keep_while(
Path, KeepWhile),
AbsKeepWhile1 = (
filter_out_irrelevant_keep_while_conds(
Path, Node, AbsKeepWhile0)),
KWMet = are_keep_while_conditions_met(
Tree, KeepWhileOnOthers),
Tree, AbsKeepWhile1),
case KWMet of
true ->
{ok, Node1, {updated, Path, Result1}};
Expand Down Expand Up @@ -739,6 +741,22 @@ insert_or_update_node_cb(_, {interrupted, Reason, Info}, _, _, _) ->
Reason1 = ?khepri_error(Reason, Info),
{error, Reason1}.

filter_out_irrelevant_keep_while_conds(
Path, {interrupted, node_not_found, #{node_is_target := true}}, KeepWhile) ->
%% A `keep_while' condition on self is irrelevant if the node does not
%% exist yet.
KeepWhile1 = maps:remove(Path, KeepWhile),
%% Likewise for `keep_while' conditions that apply to children of the
%% node.
KeepWhile2 = maps:filter(
fun(KWPath, _) ->
not lists:prefix(Path, KWPath)
end, KeepWhile1),
KeepWhile2;
filter_out_irrelevant_keep_while_conds(
_Path, _Node, KeepWhile) ->
KeepWhile.

gather_node_props_from_old_and_new_nodes(OldNode, NewNode, TreeOptions) ->
OldNodeProps = case OldNode of
undefined ->
Expand Down