Add vhost limits. #977
Merged
Add vhost limits. #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaroslaw-bochniak
approved these changes
Apr 14, 2025
Zerpet
reviewed
Apr 15, 2025
Member
Zerpet
left a comment
Zerpet
left a comment
There was a problem hiding this comment.
I'm wondering about clearing the vHost limits. The field in the spec is a pointer, so perhaps we could clear the limits if the field is nil ?
As the code stands, once a value is set, it can be lifted by setting to a negative value, but it can't be cleared.
…-operator into vhost-limits
MirahImage
force-pushed
the
vhost-limits
branch
from
db86fc9 to
6780eb0
Compare
Member
Author
|
Vhost limits can now be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #963