Skip to content

Commit 0f77218

Browse files
committed
* Re-enable ConnectionRecoveryTests one at a time.
1 parent 58a113d commit 0f77218

File tree

1 file changed

+19
-12
lines changed

1 file changed

+19
-12
lines changed

Tests/ConnectionRecoveryTests.cs

Lines changed: 19 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#if FOOBAR
21
// This source code is dual-licensed under the Apache License, version
32
// 2.0, and the Mozilla Public License, version 2.0.
43
// Copyright (c) 2017-2023 Broadcom. All Rights Reserved. The term "Broadcom" refers to Broadcom Inc. and/or its subsidiaries.
@@ -54,7 +53,7 @@ public class ConnectionRecoveryTests(ITestOutputHelper testOutputHelper)
5453
/// The error _must_ be null when the connection is closed normally even the recovery is activated.
5554
/// </summary>
5655
/// <param name="activeRecovery"> If the recovery is enabled.</param>
57-
[Theory]
56+
[SkippableTheory]
5857
[InlineData(true)]
5958
[InlineData(false)]
6059
public async Task NormalCloseTheStatusShouldBeCorrectAndErrorNull(bool activeRecovery)
@@ -104,11 +103,12 @@ public async Task NormalCloseTheStatusShouldBeCorrectAndErrorNull(bool activeRec
104103
/// then the connection is closed normally. so the status should be:
105104
/// - From Open to Closed
106105
/// </summary>
107-
[Fact]
106+
[SkippableFact]
108107
public async Task UnexpectedCloseTheStatusShouldBeCorrectAndErrorNotNull()
109108
{
110109
Assert.Null(_connection);
111110
Assert.Null(_management);
111+
Skip.If(true, "rabbitmq-dotnet-client-87");
112112

113113
IConnection connection = await AmqpConnection.CreateAsync(
114114
ConnectionSettingBuilder.Create().ContainerId(_containerId).RecoveryConfiguration(
@@ -177,11 +177,12 @@ public async Task UnexpectedCloseTheStatusShouldBeCorrectAndErrorNotNull()
177177
/// By default, the backoff is active it will be disabled after some failed attempts.
178178
/// See the BackOffDelayPolicy class for more details.
179179
/// </summary>
180-
[Fact]
180+
[SkippableFact]
181181
public async Task OverrideTheBackOffWithBackOffDisabled()
182182
{
183183
Assert.Null(_connection);
184184
Assert.Null(_management);
185+
Skip.If(true, "rabbitmq-dotnet-client-87");
185186

186187
IConnection connection = await AmqpConnection.CreateAsync(
187188
ConnectionSettingBuilder.Create().ContainerId(_containerId).RecoveryConfiguration(
@@ -240,11 +241,12 @@ public async Task OverrideTheBackOffWithBackOffDisabled()
240241
/// When the topology-recover is Enabled the temp queues should be recovered.
241242
/// the Queue is a temp queue with the Auto-Delete and Exclusive flag set to true.
242243
/// </summary>
243-
[Fact]
244+
[SkippableFact]
244245
public async Task RecoveryTopologyShouldRecoverTheTempQueues()
245246
{
246247
Assert.Null(_connection);
247248
Assert.Null(_management);
249+
Skip.If(true, "rabbitmq-dotnet-client-87");
248250

249251
string queueName = $"temp-queue-should-recover-{true}";
250252
IConnection connection = await AmqpConnection.CreateAsync(
@@ -288,11 +290,12 @@ public async Task RecoveryTopologyShouldRecoverTheTempQueues()
288290
/// When the topology-recover is Disabled the temp queues should not be recovered.
289291
/// the Queue is a temp queue with the Auto-Delete and Exclusive flag set to true.
290292
/// </summary>
291-
[Fact]
293+
[SkippableFact]
292294
public async Task RecoveryTopologyShouldNotRecoverTheTempQueues()
293295
{
294296
Assert.Null(_connection);
295297
Assert.Null(_management);
298+
Skip.If(true, "rabbitmq-dotnet-client-87");
296299

297300
string queueName = $"temp-queue-should-recover-{false}";
298301
IConnection connection = await AmqpConnection.CreateAsync(
@@ -325,13 +328,14 @@ public async Task RecoveryTopologyShouldNotRecoverTheTempQueues()
325328
Assert.Equal(0, topologyListener.QueueCount());
326329
}
327330

328-
[Theory]
331+
[SkippableTheory]
329332
[InlineData(true)]
330333
[InlineData(false)]
331334
public async Task RecoveryTopologyShouldRecoverExchanges(bool topologyEnabled)
332335
{
333336
Assert.Null(_connection);
334337
Assert.Null(_management);
338+
Skip.If(true, "rabbitmq-dotnet-client-87");
335339

336340
const string exchangeName = "exchange-should-recover";
337341
IConnection connection = await AmqpConnection.CreateAsync(
@@ -384,13 +388,14 @@ public async Task RecoveryTopologyShouldRecoverExchanges(bool topologyEnabled)
384388
connection.Dispose();
385389
}
386390

387-
[Theory]
391+
[SkippableTheory]
388392
[InlineData(true)]
389393
[InlineData(false)]
390394
public async Task RecoveryTopologyShouldRecoverBindings(bool topologyEnabled)
391395
{
392396
Assert.Null(_connection);
393397
Assert.Null(_management);
398+
Skip.If(true, "rabbitmq-dotnet-client-87");
394399

395400
IConnection connection = await AmqpConnection.CreateAsync(
396401
ConnectionSettingBuilder.Create()
@@ -467,11 +472,12 @@ await SystemUtils.WaitUntilBindingsBetweenExchangeAndQueueDontExistAsync("exchan
467472
///
468473
/// Only at the end the queue will be removed and bindings should be zero.
469474
/// </summary>
470-
[Fact]
475+
[SkippableFact]
471476
public async Task RemoveAQueueShouldRemoveTheBindings()
472477
{
473478
Assert.Null(_connection);
474479
Assert.Null(_management);
480+
Skip.If(true, "rabbitmq-dotnet-client-87");
475481

476482
IConnection connection = await AmqpConnection.CreateAsync(
477483
ConnectionSettingBuilder.Create()
@@ -529,11 +535,12 @@ await SystemUtils.WaitUntilBindingsBetweenExchangeAndQueueDontExistAsync("e-remo
529535
await connection.CloseAsync();
530536
}
531537

532-
[Fact]
538+
[SkippableFact]
533539
public async Task RemoveAnExchangeShouldRemoveTheBindings()
534540
{
535541
Assert.Null(_connection);
536542
Assert.Null(_management);
543+
Skip.If(true, "rabbitmq-dotnet-client-87");
537544

538545
IConnection connection = await AmqpConnection.CreateAsync(
539546
ConnectionSettingBuilder.Create()
@@ -596,11 +603,12 @@ await SystemUtils.WaitUntilBindingsBetweenExchangeAndQueueDontExistAsync(
596603
/// <summary>
597604
/// This test is specific to check if the bindings are removed when a destination exchange is removed.
598605
/// </summary>
599-
[Fact]
606+
[SkippableFact]
600607
public async Task RemoveAnExchangeBoundToAnotherExchangeShouldRemoveTheBindings()
601608
{
602609
Assert.Null(_connection);
603610
Assert.Null(_management);
611+
Skip.If(true, "rabbitmq-dotnet-client-87");
604612

605613
IConnection connection = await AmqpConnection.CreateAsync(
606614
ConnectionSettingBuilder.Create()
@@ -650,4 +658,3 @@ await SystemUtils.WaitUntilBindingsBetweenExchangeAndExchangeDontExistAsync(
650658
await connection.CloseAsync();
651659
}
652660
}
653-
#endif

0 commit comments

Comments
 (0)