Skip to content

Use Data Section by Default instead of AMQPValue for the message creation #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 28, 2025
Merged

Use Data Section by Default instead of AMQPValue for the message creation #116

merged 7 commits into from
Apr 28, 2025

Conversation

@Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented Apr 22, 2025 •
edited
Loading

  • Update RabbitMQ to 4.1 for windows and Linux
  • Breaking change Change the default section body for message creation. It uses Data Section (0x75) instead of AmqpValue (0x77)
    Per conversation with @ansd it is better to use Data Section for cross-protocol applications.
  • Add tests with AMQP 091
  • Fixes Message Compatibility with AMQP 0.9.x #115

@Gsantomaggio
consume form 091
6322854 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
Change the message interface from object to
ec078cc 
byte array. Change the Message body section from AMQPValue to Data. It is better for  cross protocol use cases

Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
Change the message interface from object to
da186cb 
byte array. Change the Message body section from AMQPValue to Data. It is better for  cross protocol use cases

Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
Change amqp client
56f0e0b 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
remove unsed imports
f37af29 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio changed the title consume form 091 Use ApplicationData by Default instead of AMQPValue for the message creation Apr 22, 2025
@Gsantomaggio
Copy link
Member Author

Gsantomaggio commented Apr 22, 2025

@luizcarlosfaria do you have a chance to test it? Thank you.

@Gsantomaggio Gsantomaggio mentioned this pull request Apr 22, 2025
Closed
@Gsantomaggio Gsantomaggio self-assigned this Apr 22, 2025
@Gsantomaggio Gsantomaggio added this to the 0.2.0-beta.1 milestone Apr 22, 2025
@Gsantomaggio Gsantomaggio marked this pull request as ready for review April 22, 2025 14:17
@Gsantomaggio
add tests
7e918af 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
change tests
37f6eae 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
Copy link
Member Author

Gsantomaggio commented Apr 28, 2025

@luizcarlosfaria I will merge and release.

@Gsantomaggio Gsantomaggio merged commit d584d55 into main Apr 28, 2025
2 checks passed
@Gsantomaggio Gsantomaggio deleted the add_amqp_091_tests branch April 28, 2025 07:42
@Gsantomaggio Gsantomaggio changed the title Use ApplicationData by Default instead of AMQPValue for the message creation Use Data Section by Default instead of AMQPValue for the message creation May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Gsantomaggio Gsantomaggio

Labels

None yet

Projects

None yet

Milestone

0.2.0-rc.1

Development

Successfully merging this pull request may close these issues.

Message Compatibility with AMQP 0.9.x

2 participants

@Gsantomaggio