Skip to content

Implement disposition frame with ranges #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 11, 2025
Merged

Implement disposition frame with ranges #122

merged 10 commits into from
Jun 11, 2025

Conversation

@Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented May 16, 2025 •
edited
Loading

Closes #106

@Gsantomaggio
work in progress
a6e068c 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio changed the title work in progress Implement disposition frame with ranges May 16, 2025
@Gsantomaggio
Copy link
Member Author

Gsantomaggio commented Jun 11, 2025

@lukebakken, do you have any idea why the verify does not work on Windows? It worked for a while.

@Gsantomaggio Gsantomaggio marked this pull request as ready for review June 11, 2025 11:30
@Gsantomaggio
add version
db82f4d 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
add version
04af763 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
Copy link
Member Author

Gsantomaggio commented Jun 11, 2025

It happens with dotnet 9.0.300

@Gsantomaggio
Copy link
Member Author

Gsantomaggio commented Jun 11, 2025

dotnet/sdk#49347

@lukebakken
Copy link
Contributor

lukebakken commented Jun 11, 2025

@Gsantomaggio I think this PR should be ported here - rabbitmq/rabbitmq-dotnet-client#1842

@Gsantomaggio
Copy link
Member Author

Gsantomaggio commented Jun 11, 2025

@Gsantomaggio I think this PR should be ported here - rabbitmq/rabbitmq-dotnet-client#1842

Thanks

@Gsantomaggio
pin version
1847a94 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio
pin version
6533dd1 
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio merged commit c3262ca into main Jun 11, 2025
2 checks passed
@Gsantomaggio Gsantomaggio deleted the disposition_frame branch June 11, 2025 15:08
@Gsantomaggio Gsantomaggio added this to the 0.2.2 milestone Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.2.2

Development

Successfully merging this pull request may close these issues.

Support for disposition frame with ranges

3 participants

@Gsantomaggio @lukebakken