Update CI to support OCI images from main #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Images in pivotalrabbitmq/rabbitmq built nightly from main disable the management metrics collector. This breaks many tests because we rely on management UI metrics for assertions. This commit introduces a dedicated config file to ensure that management metrics are collected.
Merged
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
Updates CI configuration to enable management metrics collection when testing with OCI images from main branch, addressing test failures caused by disabled metrics collector in pivotalrabbitmq/rabbitmq images.
- Added dedicated config files to enable management metrics collector
- Updated Docker configurations to mount the new config files
- Fixed lambda expression syntax in test assertion
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Tests/Management/ManagementTests.cs | Simplified lambda expression in test assertion |
| .ci/ubuntu/one-node/gha-setup.sh | Added volume mount for management collector config |
| .ci/ubuntu/one-node/21-enable-management-collector.conf | New config file to enable management metrics collector |
| .ci/ubuntu/cluster/rmq/Dockerfile | Added COPY command for management collector config |
| .ci/ubuntu/cluster/rmq/21-enable-management-collector.conf | New config file to enable management metrics collector |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
|
FYI @Gsantomaggio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images in pivotalrabbitmq/rabbitmq built nightly from main disable the
management metrics collector. This breaks many tests because we rely on
management UI metrics for assertions. This commit introduces a dedicated
config file to ensure that management metrics are collected.