Skip to content

Conversation

@lukebakken
Copy link
Contributor

@lukebakken lukebakken commented Jul 24, 2024

Follow-up to #27

Part of the fix to #17

  • Enable Nullable in Tests project
  • Adds support for client cert auth

Part of the fix to #17

* Make `Tests` nullable and fix errors
* Add test that uses client cert
* Pass SASL mechanism to Amqp ConnectionFactory if it's EXTERNAL
* If SaslMechanism.External is used in the builder, set user and password to null
*
* Add EasyNetQ.Management.Client dependency
* Add test that connects using client certificate
@lukebakken lukebakken self-assigned this Jul 24, 2024
@lukebakken lukebakken requested a review from Gsantomaggio July 24, 2024 22:16
@lukebakken lukebakken added this to the 0.1.0 milestone Jul 24, 2024
@Gsantomaggio Gsantomaggio marked this pull request as ready for review July 25, 2024 09:10
Gsantomaggio
Gsantomaggio previously approved these changes Jul 25, 2024
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio merged commit a4098b5 into main Jul 25, 2024
@Gsantomaggio Gsantomaggio deleted the rabbitmq-amqp-dotnet-client-17-2 branch July 25, 2024 09:25
@lukebakken lukebakken mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants