Make more non-API classes not public

Author: bording

projects/client/RabbitMQ.Client/src/client/impl/Command.cs

@@ -47,7 +47,7 @@
 
 namespace RabbitMQ.Client.Impl
 {
-    public class Command
+    class Command
     {
         // EmptyFrameSize, 8 = 1 + 2 + 4 + 1
         // - 1 byte of frame type

projects/client/RabbitMQ.Client/src/client/impl/Frame.cs

@@ -47,7 +47,7 @@
 
 namespace RabbitMQ.Client.Impl
 {
-    public class HeaderOutboundFrame : OutboundFrame
+    class HeaderOutboundFrame : OutboundFrame
     {
         private readonly ContentHeaderBase _header;
         private readonly int _bodyLength;
@@ -72,7 +72,7 @@ internal override void WritePayload(NetworkBinaryWriter writer)
         }
     }
 
-    public class BodySegmentOutboundFrame : OutboundFrame
+    class BodySegmentOutboundFrame : OutboundFrame
     {
         private readonly byte[] _body;
         private readonly int _offset;
@@ -92,7 +92,7 @@ internal override void WritePayload(NetworkBinaryWriter writer)
         }
     }
 
-    public class MethodOutboundFrame : OutboundFrame
+    class MethodOutboundFrame : OutboundFrame
     {
         private readonly MethodBase _method;
 
@@ -119,7 +119,7 @@ internal override void WritePayload(NetworkBinaryWriter writer)
         }
     }
 
-    public class EmptyOutboundFrame : OutboundFrame
+    class EmptyOutboundFrame : OutboundFrame
     {
         public EmptyOutboundFrame() : base(FrameType.FrameHeartbeat, 0)
         {
@@ -131,7 +131,7 @@ internal override void WritePayload(NetworkBinaryWriter writer)
         }
     }
 
-    public abstract class OutboundFrame : Frame
+    abstract class OutboundFrame : Frame
     {
         public OutboundFrame(FrameType type, int channel) : base(type, channel)
         {
@@ -148,7 +148,7 @@ internal void WriteTo(NetworkBinaryWriter writer)
         internal abstract void WritePayload(NetworkBinaryWriter writer);
     }
 
-    public class InboundFrame : Frame
+    class InboundFrame : Frame
     {
         private InboundFrame(FrameType type, int channel, byte[] payload) : base(type, channel, payload)
         {
@@ -242,7 +242,7 @@ internal NetworkBinaryReader GetReader()
         }
     }
 
-    public class Frame
+    class Frame
     {
         public Frame(FrameType type, int channel)
         {
@@ -292,7 +292,7 @@ public bool IsHeartbeat()
         }
     }
 
-    public enum FrameType : int
+    enum FrameType : int
     {
         FrameMethod = 1,
         FrameHeader = 2,

projects/client/RabbitMQ.Client/src/client/impl/IFrameHandler.cs

@@ -44,7 +44,7 @@
 
 namespace RabbitMQ.Client.Impl
 {
-    public interface IFrameHandler
+    interface IFrameHandler
     {
         AmqpTcpEndpoint Endpoint { get; }
 
@@ -75,4 +75,4 @@ public interface IFrameHandler
 
         void WriteFrameSet(IList<OutboundFrame> frames);
     }
-}
+}

projects/client/RabbitMQ.Client/src/client/impl/ISession.cs

@@ -43,7 +43,7 @@
 
 namespace RabbitMQ.Client.Impl
 {
-    public interface ISession
+    interface ISession
     {
         /// <summary>
         /// Gets the channel number.

projects/client/RabbitMQ.Client/src/client/impl/UnexpectedFrameException.cs

@@ -47,18 +47,13 @@ namespace RabbitMQ.Client.Impl
     /// </summary>
     public class UnexpectedFrameException : HardProtocolException
     {
-        public Frame m_frame;
-
-        public UnexpectedFrameException(Frame frame)
+        internal UnexpectedFrameException(Frame frame)
             : base("A frame of this type was not expected at this time")
         {
-            m_frame = frame;
+            Frame = frame;
         }
 
-        public Frame Frame
-        {
-            get { return m_frame; }
-        }
+        internal  Frame Frame { get; }
 
         public override ushort ReplyCode
         {

projects/client/Unit/src/unit/APIApproval.Approve.approved.txt

@@ -763,93 +763,21 @@ namespace RabbitMQ.Client.Exceptions
 }
 namespace RabbitMQ.Client.Impl
 {
-    public class BodySegmentOutboundFrame : RabbitMQ.Client.Impl.OutboundFrame
-    {
-        public BodySegmentOutboundFrame(int channel, byte[] body, int offset, int count) { }
-    }
     public class ChannelErrorException : RabbitMQ.Client.Impl.HardProtocolException
     {
         public ChannelErrorException(int channel) { }
         public int Channel { get; }
         public override ushort ReplyCode { get; }
     }
-    public class Command
-    {
-        public byte[] Body { get; }
-        public static void CheckEmptyFrameSize() { }
-    }
-    public class EmptyOutboundFrame : RabbitMQ.Client.Impl.OutboundFrame
-    {
-        public EmptyOutboundFrame() { }
-    }
-    public class Frame
-    {
-        public Frame(RabbitMQ.Client.Impl.FrameType type, int channel) { }
-        public Frame(RabbitMQ.Client.Impl.FrameType type, int channel, byte[] payload) { }
-        public int Channel { get; }
-        public byte[] Payload { get; }
-        public RabbitMQ.Client.Impl.FrameType Type { get; }
-        public bool IsBody() { }
-        public bool IsHeader() { }
-        public bool IsHeartbeat() { }
-        public bool IsMethod() { }
-        public override string ToString() { }
-    }
-    public enum FrameType
-    {
-        FrameMethod = 1,
-        FrameHeader = 2,
-        FrameBody = 3,
-        FrameHeartbeat = 8,
-        FrameEnd = 206,
-        FrameMinSize = 4096,
-    }
     public abstract class HardProtocolException : RabbitMQ.Client.Impl.ProtocolException
     {
         protected HardProtocolException(string message) { }
     }
-    public class HeaderOutboundFrame : RabbitMQ.Client.Impl.OutboundFrame { }
-    public interface IFrameHandler
-    {
-        RabbitMQ.Client.AmqpTcpEndpoint Endpoint { get; }
-        System.Net.EndPoint LocalEndPoint { get; }
-        int LocalPort { get; }
-        System.TimeSpan ReadTimeout { set; }
-        System.Net.EndPoint RemoteEndPoint { get; }
-        int RemotePort { get; }
-        System.TimeSpan WriteTimeout { set; }
-        void Close();
-        RabbitMQ.Client.Impl.InboundFrame ReadFrame();
-        void SendHeader();
-        void WriteFrame(RabbitMQ.Client.Impl.OutboundFrame frame);
-        void WriteFrameSet(System.Collections.Generic.IList<RabbitMQ.Client.Impl.OutboundFrame> frames);
-    }
-    public interface ISession
-    {
-        int ChannelNumber { get; }
-        RabbitMQ.Client.ShutdownEventArgs CloseReason { get; }
-        System.Action<RabbitMQ.Client.Impl.ISession, RabbitMQ.Client.Impl.Command> CommandReceived { get; set; }
-        RabbitMQ.Client.IConnection Connection { get; }
-        bool IsOpen { get; }
-        event System.EventHandler<RabbitMQ.Client.ShutdownEventArgs> SessionShutdown;
-        void Close(RabbitMQ.Client.ShutdownEventArgs reason);
-        void Close(RabbitMQ.Client.ShutdownEventArgs reason, bool notify);
-        void HandleFrame(RabbitMQ.Client.Impl.InboundFrame frame);
-        void Notify();
-        void Transmit(RabbitMQ.Client.Impl.Command cmd);
-        void Transmit(System.Collections.Generic.IList<RabbitMQ.Client.Impl.Command> cmd);
-    }
-    public class InboundFrame : RabbitMQ.Client.Impl.Frame { }
     public class MalformedFrameException : RabbitMQ.Client.Impl.HardProtocolException
     {
         public MalformedFrameException(string message) { }
         public override ushort ReplyCode { get; }
     }
-    public class MethodOutboundFrame : RabbitMQ.Client.Impl.OutboundFrame { }
-    public abstract class OutboundFrame : RabbitMQ.Client.Impl.Frame
-    {
-        public OutboundFrame(RabbitMQ.Client.Impl.FrameType type, int channel) { }
-    }
     public abstract class ProtocolException : RabbitMQ.Client.Exceptions.RabbitMQClientException
     {
         protected ProtocolException(string message) { }
@@ -868,9 +796,6 @@ namespace RabbitMQ.Client.Impl
     }
     public class UnexpectedFrameException : RabbitMQ.Client.Impl.HardProtocolException
     {
-        public RabbitMQ.Client.Impl.Frame m_frame;
-        public UnexpectedFrameException(RabbitMQ.Client.Impl.Frame frame) { }
-        public RabbitMQ.Client.Impl.Frame Frame { get; }
         public override ushort ReplyCode { get; }
     }
     public class UnknownClassOrMethodException : RabbitMQ.Client.Impl.HardProtocolException