Investigate & fix SemaphoreFullException
#1819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1818
branch
from
e5e3ba5 to
f4ba70e
Compare
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1818
branch
from
24fa327 to
0ae8d39
Compare
Fixes #1818 Start by modifying test to concurrently publish to the same `IChannel` instance. * Add queue arguments to test to simulate nacks. * Consolidate duplicated code. * Remove TCS from `_confirmsTaskCompletionSources` if there is an `OperationCanceledException`. * Consistently use `TryRemove` * Remove use of `Debug.Assert`
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1818
branch
from
0ae8d39 to
6098e44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1818
Start by modifying test to concurrently publish to the same
IChannelinstance.