Skip to content

fix: prevent possible connection leak in AutorecoveringConnection during creation #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

krisz2000
Copy link
Contributor

Proposed Changes

Fixes #1856

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue Possible connection leak when trying to create first connection #1856)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

@krisz2000 krisz2000 force-pushed the fix-autorecovering-connection-connection-leak-on-creation branch from b003942 to f95fcd0 Compare August 8, 2025 20:28
@lukebakken lukebakken self-assigned this Aug 8, 2025
@lukebakken lukebakken self-requested a review August 8, 2025 21:17
@lukebakken lukebakken added this to the 7.2.0 milestone Aug 8, 2025
…on after inner connection open error

This matches the behavior used when normal connection opening fails.
@lukebakken lukebakken merged commit 44d8be3 into rabbitmq:main Aug 9, 2025
10 checks passed
@lukebakken
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible connection leak when trying to create first connection
2 participants