Skip to content

Allow for messages up to the modern RabbitMQ hard upper limit (of 512 MiB) #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Allow for messages up to the modern RabbitMQ hard upper limit (of 512 MiB) #1861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/RabbitMQ.Client/AmqpTcpEndpoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public AmqpTcpEndpoint(string hostName, int portOrMinusOne, SslOption ssl,
_port = portOrMinusOne;
Ssl = ssl;
_maxInboundMessageBodySize = Math.Min(maxInboundMessageBodySize,
InternalConstants.DefaultRabbitMqMaxInboundMessageBodySize);
InternalConstants.MaximumRabbitMqMaxInboundMessageBodySize);
}

/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions projects/RabbitMQ.Client/InternalConstants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ internal static class InternalConstants
/// <summary>
/// Largest message size, in bytes, allowed in RabbitMQ.
/// Note: <code>rabbit.max_message_size</code> setting (https://www.rabbitmq.com/configure.html)
/// configures the largest message size which should be lower than this maximum of 128MiB.
/// configures the largest message size which should not be higher than this maximum of 512MiB.
/// </summary>
internal const uint DefaultRabbitMqMaxInboundMessageBodySize = 1_048_576 * 128;
internal const uint MaximumRabbitMqMaxInboundMessageBodySize = 1_048_576 * 512;

/// <summary>
/// Largest client provide name, in characters, allowed in RabbitMQ.
Expand Down
4 changes: 2 additions & 2 deletions projects/Test/Integration/TestConnectionFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,8 +320,8 @@ public async Task TestCreateConnectionUsesValidEndpointWhenMultipleSupplied()
public void TestCreateAmqpTCPEndPointOverridesMaxMessageSizeWhenGreaterThanMaximumAllowed()
{
var ep = new AmqpTcpEndpoint("localhost", -1, new SslOption(),
2 * InternalConstants.DefaultRabbitMqMaxInboundMessageBodySize);
Assert.Equal(InternalConstants.DefaultRabbitMqMaxInboundMessageBodySize, ep.MaxInboundMessageBodySize);
2 * InternalConstants.MaximumRabbitMqMaxInboundMessageBodySize);
Assert.Equal(InternalConstants.MaximumRabbitMqMaxInboundMessageBodySize, ep.MaxInboundMessageBodySize);
}

[Fact]
Expand Down
Loading