Make instance variables in Frame private #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

michaelklishin merged 1 commit into rabbitmq:master from asomov:private-state

Aug 23, 2019

Contributor

asomov commented Aug 23, 2019

Refactor: make the instance variables private and use getters

Types of Changes

[x ] Cosmetics (whitespace, appearance)

Checklist

[ x] I have read the CONTRIBUTING.md document
I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
[x ] All tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)
Any dependent changes have been merged and published in related repositories


          Make instance variables in Frame private

af44bfb

michaelklishin approved these changes

View reviewed changes

michaelklishin merged commit c8dfec9 into rabbitmq:master

michaelklishin added this to the 6.0.0 milestone

Contributor

michaelklishin commented Aug 23, 2019

Thank you. Please note that this can only go into 6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet