Dispatch messages only when channel is open #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes PerfTest more reactive with large prefetch and long processing times: client TCP buffer gets full, the broker cannot write to the client socket, it closes the connection (after a 30-second timeout by default), the client tries to close the connection channels, but it uses the consumer dispatcher to do so, and it is busy processing the slow messages, so the channels are never properly shut down. Recovery cannot occur then. By dispatching messages only when the channel is open, the consumer dispatcher backlog gets cleared right away, channels get closed normally and recovery can kick in.
michaelklishin
approved these changes
Mar 18, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
Dispatch messages only when channel is open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes PerfTest more reactive with large prefetch and long processing times: client TCP buffer gets full, the broker cannot write to the client socket, it closes the connection (after a 30-second timeout by default), the client tries to close the connection channels, but it uses the consumer dispatcher to do so, and it is busy processing the slow messages, so the channels are never properly shut down. Recovery cannot occur then.
By dispatching messages only when the channel is open, the consumer dispatcher backlog gets cleared right away, channels get closed normally and recovery can kick in.