Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented May 21, 2024

Proposed Changes

The current vhost queue limit it's only applicable to AMQP 0.9.1 and "non-native" protocols.

This PR moves the check to rabbit_queue_type:declare

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.


This is an automatic backport of pull request #11222 done by [Mergify](https://mergify.com).

SimonUnge added 5 commits May 21, 2024 17:29
(cherry picked from commit d2192fb)
(cherry picked from commit a5214f3)
(cherry picked from commit 4a6c009)
@michaelklishin michaelklishin added this to the 3.13.3 milestone May 21, 2024
@michaelklishin michaelklishin merged commit 3b986c3 into v3.13.x May 21, 2024
@michaelklishin michaelklishin deleted the mergify/bp/v3.13.x/pr-11222 branch May 21, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants