Fix quorum queue credit reply crash in AMQP session #11846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansd
force-pushed
the
credit-reply-crash
branch
3 times, most recently
from
7ae2615 to
f3bd5ea
Compare
Fixes #11841 PR #11307 introduced the invariant that at most one credit request between session proc and quorum queue proc can be in flight at any given time. This is not the case when rabbit_fifo_client re-sends credit requests on behalf of the session proc when the quorum queue leader changes. This commit therefore removes assertions which assumed only a single credit request to be in flight. This commit also removes field queue_flow_ctl.desired_credit since it is redundant to field client_flow_ctl.credit
michaelklishin
approved these changes
Jul 28, 2024
Collaborator
|
Thank you for the reproduction steps in #11841. |
michaelklishin
added a commit
that referenced
this pull request
Jul 29, 2024
Fix quorum queue credit reply crash in AMQP session (backport #11846)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11841
PR #11307 introduced the assertion that at most one credit request between session proc and quorum queue proc can be in flight at any given time. However, this is not the case when
rabbit_fifo_clientre-sends credit requests on behalf of the session proc when the quorum queue leader changes.This commit therefore removes assertions which assumed only a single credit request to be in flight.
This commit also removes field
queue_flow_ctl.desired_creditsince it is redundant to fieldclient_flow_ctl.credit