Skip to content

Minor fix: GET/HEAD method on non existing shovel crash (backport #12172) (backport #12174) #12175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Minor fix: GET/HEAD method on non existing shovel crash (backport #12172) (backport #12174) #12175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions deps/rabbitmq_shovel_management/src/rabbit_shovel_mgmt_shovel.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,22 @@ resource_exists(ReqData, Context) ->
case name(ReqData) of
none -> true;
Name ->
%% Deleting or restarting a shovel
case get_shovel_node(VHost, Name, ReqData, Context) of
undefined ->
rabbit_log:error("Shovel with the name '~ts' was not found on virtual host '~ts'. "
"It may be failing to connect and report its status.",
[Name, VHost]),
case is_restart(ReqData) of
true -> false;
%% this is a deletion attempt, it can continue and idempotently try to
%% delete the shovel
false -> true
case cowboy_req:method(ReqData) of
<<"DELETE">> ->
%% Deleting or restarting a shovel
case is_restart(ReqData) of
true -> false;
%% this is a deletion attempt, it can continue and idempotently try to
%% delete the shovel
false -> true
end;
_ ->
false
end;
_ ->
true
Expand Down