Fix the exit status when parallel-ct is used #12425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoguin
force-pushed
the
loic-fix-parallel-ct-exit-status
branch
5 times, most recently
from
179467b to
0d8f9c8
Compare
The problem comes from `ct_master` which doesn't tell us in the return value whether the tests succeeded. In order to get that information a CT hook was created. But then we run into another problem: despite its documentation claiming otherwise, `ct_master` does not handle `ct_hooks` instructions in the test spec. So for the time being we fork `ct_master` into a new `ct_master_fork` module and insert our hook directly in the code. Later on we will submit patches to OTP.
lhoguin
force-pushed
the
loic-fix-parallel-ct-exit-status
branch
from
0d8f9c8 to
9645fb1
Compare
lhoguin
changed the title
Contributor
Author
|
Rebased and pushed. Once it's green (minus the failures caused by OTP-27 bugs) I will merge. |
Contributor
Author
|
The two known issues are:
The rest of the tests being OK this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes CI mistakenly consider failures as success for
rabbitandrabbitmq_mqtt.