Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Oct 30, 2024

Proposed Changes

It fixes an issue caused when the mqtt.ssl_cert_client_id_san_type was renamed in the schema to 'mqtt.ssl_cert_login_san_type` to keep it consistent with how the username is determined. But one part of the code was not updated accordingly.

Adding a selenium end-2-end test so that this kind of issues are spotted earlier.

References #12595.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue Cannot set mqtt.ssl_cert_client_id_san_type and san_index #12595)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

This is an automatic backport of pull request #12604 done by [Mergify](https://mergify.com).

@mergify mergify bot added the bazel label Oct 30, 2024
@michaelklishin michaelklishin added this to the 4.0.4 milestone Oct 30, 2024
@michaelklishin michaelklishin merged commit 77867be into v4.0.x Oct 30, 2024
196 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v4.0.x/pr-12604 branch October 30, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants