Skip to content

Conversation

@michaelklishin
Copy link
Collaborator

@michaelklishin michaelklishin commented Nov 5, 2024

This is #12665 by @LoisSotoLopez. References #12412 #12640 #12641.

@mergify
Copy link

mergify bot commented Nov 5, 2024

⚠️ The sha of the head commit of this PR conflicts with #12665. Mergify cannot evaluate rules on this PR. ⚠️

@mkuratczyk
Copy link
Contributor

If possible, the test condition should not be "if it's a mixed version test" but something specific to 4.0-4.1 upgrade.
Once mixed version tests run 4.1-4.2 or anything beyond, it should run without further actions (performing which we are likely to forget)

@michaelklishin
Copy link
Collaborator Author

@mkuratczyk you are right but we do not have such a mechanism in CT helpers. And some of our team members have discussed revisiting such excluded tests for 4.1.x specifically, so I think we won't necessarily forget about them.

@michaelklishin
Copy link
Collaborator Author

michaelklishin commented Nov 5, 2024

Given that the majority of such excluded tests can be re-enabled when a release series rolls over, so the "old" series "gain" the behavior previous present only in main, I don't think we necessarily need an exclusion mechanism for a specific pair of versions.

There are so many build system-related changes going on that I'd rather not try to introduce it in the next few months.

@michaelklishin
Copy link
Collaborator Author

Per discussion on the team: we will have to revisit such checks after every release, because in a (future) 4.1/4.0 combination, this test would pass and can be run in mixed version mode.

In the future we will likely support N-2 upgrades (this is not a promise of delivery but just an idea on the team), in which case we'd need new helpers that detect/exclude specific combinations of release series, e.g. 4.1.x and 3.13.x but not 4.1.x and 4.0.x.

@michaelklishin michaelklishin merged commit 018831a into main Nov 5, 2024
536 of 540 checks passed
@michaelklishin michaelklishin deleted the rabbitmq-server-12665 branch November 5, 2024 16:28
michaelklishin added a commit that referenced this pull request Nov 5, 2024
michaelklishin added a commit that referenced this pull request Nov 5, 2024
By @LoisSotoLopez: Exclude policy_repair QQ test on mixed versions (backport #12666)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants