rabbit_amqqueue: Add is_feature_used callback to transient_nonexcl_queues depr. feature
#12674
+50
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
add-is_feature_used-callback-to-transient_nonexcl_queues-depr-feature
branch
2 times, most recently
from
e20ef6b to
da82a7d
Compare
…_queues` depr. feature [Why] Without this callback, the deprecated features subsystem can't report if the feature is used or not. This reduces the usefulness of the HTTP API endpoint or the CLI command that help verify if a cluster is using deprecated features. [How] The callback counts transient non-exclusive queues and return `true` if there are one or more of them. References #12619.
dumbbell
force-pushed
the
add-is_feature_used-callback-to-transient_nonexcl_queues-depr-feature
branch
from
da82a7d to
638e3a4
Compare
michaelklishin
approved these changes
Nov 14, 2024
michaelklishin
deleted the
add-is_feature_used-callback-to-transient_nonexcl_queues-depr-feature
branch
dumbbell
added a commit
that referenced
this pull request
Nov 15, 2024
rabbit_amqqueue: Add `is_feature_used` callback to `transient_nonexcl_queues` depr. feature (backport #12674)
gomoripeti
reviewed
Nov 19, 2024
| khepri => fun() -> list_transient_in_khepri() end | ||
| }). | ||
|
|
||
| list_transient_in_mnesia() -> |
Contributor
There was a problem hiding this comment.
sorry for the late comment, but to me it looks like if mnesia is used, this will list all queues, not just transient ones.
I get a "Deprecated features are being used" "transient_nonexcl_queues | In use Permitted by default" warning when I have a single durable quorum queue.
> rabbit_db_queue:list_transient().
{ok,[#amqqueue{name = #resource{virtual_host = <<"/">>,
kind = queue,name = <<"qq1">>},
durable = true,auto_delete = false,exclusive_owner = none,
...
Collaborator
Author
There was a problem hiding this comment.
Then there is a long-standing bug in this function. Could you please file an issue for it? I can’t work on this one right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Without this callback, the deprecated features subsystem can't report if the feature is used or not.
This reduces the usefulness of the HTTP API endpoint or the CLI command that help verify if a cluster is using deprecated features.
How
The callback counts transient non-exclusive queues and return
trueif there are one or more of them.References #12619.