QQ: reduce memory use when dropping many messages at once. #12712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As may happen when a max_length configuration change is made when there are many messages on the queue.
mkuratczyk
approved these changes
Nov 13, 2024
Contributor
mkuratczyk
left a comment
mkuratczyk
left a comment
There was a problem hiding this comment.
There's still a spike, but significantly smaller. Given this test case is pretty extreme (drops almost 5M messages), this should be fine for pretty much all normal situations.
the-mikedavis
approved these changes
Nov 13, 2024
michaelklishin
approved these changes
Nov 13, 2024
michaelklishin
added a commit
that referenced
this pull request
Nov 13, 2024
QQ: reduce memory use when dropping many messages at once. (backport #12712)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As may happen when a max_length configuration change is made when there are many messages on the queue.
Fixes #12608