Grafana Dashboards: Fix Query Errors and Improve Instance Filtering in Erlang Distribution and BEAM Dashboards (backport #12720) #12725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated metric expressions to include instance filtering with {instance=\"$node\"}
for the following metrics:
- erlang_vm_statistics_run_queues_length
- erlang_vm_statistics_dirty_io_run_queue_length
- erlang_vm_statistics_dirty_cpu_run_queue_length
- Added 'DS_PROMETHEUS' as a templated data source variable
(cherry picked from commit b9dc0ea)
- Modified metric expression and legend format in State of distribution links - Changed panel type from 'flant-statusmap-panel' to 'status-history' for Process state (cherry picked from commit dc9311a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Hi,
During the testing with Grafana 11.3.0 and RabbitMQ 3.13.7, deployed on Kubernetes, we noticed several issues with the Erlang Distribution and Erlang BEAM dashboards.
Erlang Distribution dashboard:
The "State of distribution links" panel on the Erlang Distribution dashboard was failing due to a query error caused by duplicate series in the match group, resulting in many-to-many matching conflicts.
The "Process state" panel was unable to display correctly due to the flant status map being deprecated.
Erlang-BEAM dashboard:
Data was unable to be retrieved due to the missing DS_Prometheus variable, which was not defined as a datasource.
The "Erlang VM Run Queue Length" panel displayed data for all nodes in the cluster rather than filtering to show data only for the selected node.
Changes:
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.
This is an automatic backport of pull request #12720 done by [Mergify](https://mergify.com).