rabbit_vhosts: Don't reconcile vhosts if rabbit is stopped
#12799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] That timer was started during boot and continued regardless if `rabbit` was running or stopped. This caused the reconsiliation to crash if the `rabbit` app was stopped before the it ended because it tried to access the database even though it was stopped or even reset. [How] We just check if `rabbit` is running before running one reconciliation and scheduling a new one.
[How] The function now accepts that the node to reset is already out of the cluster. This avoids a mismatch exception for a situation that is ok.
dumbbell
added a commit
that referenced
this pull request
Nov 25, 2024
rabbit_vhosts: Don't reconcile vhosts if `rabbit` is stopped (backport #12799)
Collaborator
|
Good catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
That timer was started during boot and continued regardless if
rabbitwas running or stopped.This caused the reconsiliation to crash if the
rabbitapp was stopped before the it ended because it tried to access the database even though it was stopped or even reset.How
We just check if
rabbitis running before running one reconciliation and scheduling a new one.