rabbitmq_peer_discovery_etcd: Wait for etcd start in system_SUITE #12985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
wait-for-etcd-start
branch
from
93bdebd to
27f928b
Compare
[Why] It was possible that testcases were executed before the etcd daemon was ready, leading to test failures. [How] There was already a santy check to verify that the etcd daemon was working correctly, but it was itself a testcase. This patch moves this code to the etcd start code to wait for it to be ready. This replaces the previous workaround of waiting for 2 seconds. While here, log anything printed to stdout/stderr by etcd after it exited. Fixes #12981.
dumbbell
force-pushed
the
wait-for-etcd-start
branch
from
27f928b to
d54b2bf
Compare
Collaborator
|
@Mergifyio backport v4.0.x |
✅ Backports have been created
|
michaelklishin
added a commit
that referenced
this pull request
Dec 19, 2024
michaelklishin
added a commit
that referenced
this pull request
Dec 20, 2024
rabbitmq_peer_discovery_etcd: Wait for etcd start in system_SUITE (backport #12985)
Member
|
Thank you @dumbbell ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It was possible that testcases were executed before the etcd daemon was ready, leading to test failures.
How
There was already a sanity check to verify that the etcd daemon was working correctly, but it was itself a testcase.
This patch moves this code to the etcd start code to wait for it to be ready.
This replaces the previous workaround of waiting for 2 seconds.
While here, log anything printed to stdout/stderr by etcd after it exited.
Fixes #12981.