Skip to content

Conversation

@michaelklishin
Copy link
Collaborator

There are no functional changes to this massive diff.

Note that this won't be backported but the same change should be applied to other long-lived branches to avoid silly conflicts during backports.

There are no functional changes to this massive diff.
@michaelklishin michaelklishin added this to the 4.1.0 milestone Jan 1, 2025
@lukebakken
Copy link
Collaborator

When this is merged, add the commit SHA to this file:

https://github.com/rabbitmq/rabbitmq-server/blob/main/.git-blame-ignore-revs

@michaelklishin
Copy link
Collaborator Author

The AWS peer discovery suite fails because it still uses Bazel and it runs into an issue (addressed for at least some cases) with BUILD.horus and the actual Horus repo structure not matching up.

@the-mikedavis
Copy link
Collaborator

@michaelklishin I pushed up e1e9191 which should fix the Bazel build

@michaelklishin
Copy link
Collaborator Author

michaelklishin commented Jan 2, 2025

The mirrored_supervisor_SUITE fails due to the following exceptions found in the logs even though I see no evidence of any functional issues:

*** User 2025-01-02 03:34:43.002 ***[🔗](https://github.com/rabbitmq/rabbitmq-server/pull/13008#e-229)
gen_server termination:

2025-01-02 03:34:32.965013+00:00 [error] <0.551.0> ** Generic server migrate2 terminating
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0> ** Last message in was {'EXIT',<0.547.0>,bang}
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0> ** When Server state == {state,
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0>                          {local,migrate2},
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0>                          one_for_all,
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0>                          {[mirroring,delegate],
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0>                           #{delegate =>
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0>                              {child,<0.552.0>,delegate,
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0>                               {supervisor2,start_link,
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0>                                [mirrored_supervisor_sups,
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0>                                 {delegate,{one_for_one,0,1}}]},
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0>                               temporary,4294967295,supervisor,
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0>                               [supervisor2]},
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0>                             mirroring =>
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0>                              {child,<0.553.0>,mirroring,
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0>                               {mirrored_supervisor,start_internal,
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0>                                [migrate,[]]},
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0>                               permanent,4294967295,worker,
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0>                               [mirrored_supervisor_sups]}}},
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0>                          undefined,0,1,[],0,mirrored_supervisor_sups,
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0>                          {overall,migrate,{ok,{{one_for_one,0,1},[]}}}}
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0> ** Reason for termination ==
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0> ** bang
2025-01-02 03:34:32.965013+00:00 [error] <0.551.0> 
2025-01-02 03:34:32.966121+00:00 [error] <0.551.0>   crasher:
2025-01-02 03:34:32.966121+00:00 [error] <0.551.0>     initial call: supervisor2:init/1
2025-01-02 03:34:32.966121+00:00 [error] <0.551.0>     pid: <0.551.0>
2025-01-02 03:34:32.966121+00:00 [error] <0.551.0>     registered_name: migrate2
2025-01-02 03:34:32.966121+00:00 [error] <0.551.0>     exception exit: bang
2025-01-02 03:34:32.966121+00:00 [error] <0.551.0>       in function  gen_server:decode_msg/9 (gen_server.erl, line 1049)
2025-01-02 03:34:32.966121+00:00 [error] <0.551.0>     ancestors: [<0.547.0>]
2025-01-02 03:34:32.966121+00:00 [error] <0.551.0>     message_queue_len: 0
2025-01-02 03:34:32.966121+00:00 [error] <0.551.0>     messages: []
2025-01-02 03:34:32.966121+00:00 [error] <0.551.0>     links: []
2025-01-02 03:34:32.966121+00:00 [error] <0.551.0>     dictionary: []
2025-01-02 03:34:32.966121+00:00 [error] <0.551.0>     trap_exit: true
2025-01-02 03:34:32.966121+00:00 [error] <0.551.0>     status: running
2025-01-02 03:34:32.966121+00:00 [error] <0.551.0>     heap_size: 6772
2025-01-02 03:34:32.966121+00:00 [error] <0.551.0>     stack_size: 28
2025-01-02 03:34:32.966121+00:00 [error] <0.551.0>     reductions: 19409
2025-01-02 03:34:32.966121+00:00 [error] <0.551.0>   neighbours:
2025-01-02 03:34:32.966121+00:00 [error] <0.551.0>

I will disable exception search for that suite specifically.

@michaelklishin michaelklishin merged commit d56522a into main Jan 2, 2025
273 checks passed
@michaelklishin michaelklishin deleted the mk-copyright-year-bump branch January 2, 2025 17:05
michaelklishin added a commit that referenced this pull request Jan 2, 2025
michaelklishin added a commit that referenced this pull request Jan 2, 2025
michaelklishin added a commit that referenced this pull request Jan 2, 2025
michaelklishin added a commit that referenced this pull request Jan 2, 2025
Take 2, this file set avoids CLI tools issues
on CI.

References #13008 #13011
michaelklishin added a commit that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants