Skip to content

Delete stream consumer metrics when AMQP 091 connection closes #13085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2025
Merged

Delete stream consumer metrics when AMQP 091 connection closes #13085

merged 1 commit into from
Jan 16, 2025

Conversation

@acogoluegnes
Copy link
Contributor

@acogoluegnes acogoluegnes commented Jan 16, 2025

To avoid rogue consumer records.

@acogoluegnes acogoluegnes added this to the 4.1.0 milestone Jan 16, 2025
@acogoluegnes acogoluegnes marked this pull request as ready for review January 16, 2025 13:02
@mkuratczyk mkuratczyk self-requested a review January 16, 2025 14:39
@mkuratczyk mkuratczyk merged commit 114a5c2 into main Jan 16, 2025
272 checks passed
@mkuratczyk mkuratczyk deleted the stream-queue-delete-consumer-metrics-when-connection-closes branch January 16, 2025 14:40
mergify bot pushed a commit that referenced this pull request Jan 16, 2025
@acogoluegnes @mergify
Delete stream consumer metrics when AMQP 091 connection closes (#13085)
21e69e3 
To avoid rogue consumer records.

(cherry picked from commit 114a5c2)
@mergify mergify bot mentioned this pull request Jan 16, 2025
Merged
@ansd
Copy link
Member

ansd commented Jan 16, 2025

Not sure whether it's relevant or not, but commenting here just in case:
In #9356 we decided to omit the consumer_deleted events in classic queues since they seem to have caused performance issues.

michaelklishin added a commit that referenced this pull request Jan 16, 2025
@michaelklishin
Merge pull request #13086 from rabbitmq/mergify/bp/v4.0.x/pr-13085
0cd2b3e 
Delete stream consumer metrics when AMQP 091 connection closes (backport #13085)
acogoluegnes added a commit that referenced this pull request Jan 17, 2025
@acogoluegnes
Emit cancellation event only when stream consumer is cancelled
5c19e4e 
Not when the channel or the connection is closed.

References #13085, #9356
@acogoluegnes acogoluegnes mentioned this pull request Jan 17, 2025
Merged
@acogoluegnes
Copy link
Contributor Author

acogoluegnes commented Jan 17, 2025

Not sure whether it's relevant or not, but commenting here just in case: In #9356 we decided to omit the consumer_deleted events in classic queues since they seem to have caused performance issues.

Right, I submitted a follow-up PR: #13092.

acogoluegnes added a commit that referenced this pull request Jan 17, 2025
@acogoluegnes
Emit cancellation event only when stream consumer is cancelled
69d0382 
Not when the channel or the connection is closed.

References #13085, #9356
mergify bot pushed a commit that referenced this pull request Jan 17, 2025
@acogoluegnes @mergify
Emit cancellation event only when stream consumer is cancelled
cac0839 
Not when the channel or the connection is closed.

References #13085, #9356

(cherry picked from commit 69d0382)

# Conflicts:
#	deps/rabbitmq_stream/src/rabbit_stream_reader.erl
@mergify mergify bot mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkuratczyk mkuratczyk mkuratczyk approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@acogoluegnes @ansd @mkuratczyk