Skip to content

Conversation

@SimonUnge
Copy link
Collaborator

but the component count is over all vhost in the cluster.
Very minor fix.

Proposed Changes

Remove the mention of 'per node' in the log msg as it is not correct, its per cluster.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.

@michaelklishin michaelklishin added this to the 4.1.0 milestone Jan 24, 2025
@michaelklishin michaelklishin merged commit 79dd503 into main Jan 24, 2025
267 of 272 checks passed
@michaelklishin michaelklishin deleted the su_aws/limit_logging_error branch January 24, 2025 19:10
@michaelklishin
Copy link
Collaborator

@SimonUnge I had to revert this change, it breaks a test suite, see #13152.

@michaelklishin michaelklishin removed this from the 4.1.0 milestone Jan 24, 2025
@michaelklishin michaelklishin changed the title Log incorrectly claims the limit is per node, [Reverted] Log incorrectly claims the limit is per node, Jan 24, 2025
@SimonUnge
Copy link
Collaborator Author

My bad, will update test, new PR. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants