Depends on #12753: Use local read to check node is in maintenance #13172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In stream reader. The consistent read may cause some timeout for the metadata frame.
Collaborator
|
A local read should be perfectly sufficient in this case. |
Contributor
Author
|
It is likely to be due to the version mismatch between Khepri and RA (we upgraded RA to 2.16 in RabbitMQ, but Khepri is not fully compatible with it). I agree the stream plugin could use a local read in this case, even though the metadata frame can be used when there is instability in the cluster (client applications recovering their connection during a rolling upgrade/restart). Maybe we should wait for #12753 to be merged and make sure it fixes the flake before changing the stream plugin to use a local read. |
Merged
Collaborator
|
Yes, we can wait for #12753. |
michaelklishin
changed the title
Collaborator
|
This should no longer be necessary with Khepri Per discussion with @acogoluegnes @kjnilsson. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In stream reader. The consistent read may cause some timeout for the metadata frame (when Khepri is used as the data store).
Depends on #12753.