Skip to content

Configure location of mocha-test dockerfile (backport #13389) #13392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Configure location of mocha-test dockerfile (backport #13389) #13392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
665ad58
Configure location of mocha-test dockerfile
MarcialRosales Feb 21, 2025
371118a
Remove duplicate flag
MarcialRosales Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions selenium/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,3 +209,10 @@ following command:
```
npm install
```

## Build mocha-test image using a different Dockefile

```bash
MOCHA_DOCKER_FILE=\location\of\my\Dockerfile ./run-suites.sh
```

8 changes: 6 additions & 2 deletions selenium/bin/suite_template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,15 @@ init_suite() {
}

build_mocha_image() {
begin "Ensuring mocha-test image ..."
DOCKER_BUILD_ARGS=""
if [[ -n "$MOCHA_DOCKER_FILE" ]]; then
DOCKER_BUILD_ARGS="-f $MOCHA_DOCKER_FILE "
fi
begin "Ensuring mocha-test image ($DOCKER_BUILD_ARGS) ..."
tag=($(md5sum $SELENIUM_ROOT_FOLDER/package.json))
print "> tag : $tag"
if [[ $(docker images -q mocha-test:$tag 2> /dev/null) == "" ]]; then
docker build -t mocha-test:$tag --target test $SELENIUM_ROOT_FOLDER
docker build $DOCKER_BUILD_ARGS -t mocha-test:$tag --target test $SELENIUM_ROOT_FOLDER
print "> Built docker image mocha-test:$tag"
fi
end "mocha-test image exists"
Expand Down
Loading