Add dynamic socket buffer functionality to rabbit_reader (backport #13363) #13436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `buffer` socket option will be changed dynamically based on how much data is received. This is restricted to AMQP protocols (old and 1.0). The algorithm is a little different than Cowboy 2.13. The moving average is less reactive (div 8 instead of 2) and floats are used so that using smaller lower buffer values is possible (otherwise the rounding prevents increasing buffer sizes). The lower buffer size was set to 128 as a result. Compared to the previous which was to set `buffer` to `rcvbuf` effectively, often to 131072 on Linux for example, the performance sees a slight improvement in various scenarios for all message sizes using AMQP-0.9.1 and a lower memory usage as well. But the difference is small in the benchmarks we have run (5% to 10%), whereas Cowboy saw a huge improvement because its default was very small (1460). For AMQP-1.0 this seems to be no worse but we didn't detect a clear improvement. We saw scenarios where small message sizes showed improvement, and large message sizes showed a regression. But we are even less confident with these results. David (AMQP-1.0 native developer) ran a few tests and didn't see a regression. The dynamic buffer code is currently identical for old and 1.0 AMQP. But we might tweak them differently in the future so they're left as duplicate for now. This is because different protocols have different behaviors and so the algorithm may need to be tweaked differently for each protocol. (cherry picked from commit 5344410)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #13363 done by [Mergify](https://mergify.com).