Skip to content

Conversation

@ikavgo
Copy link
Contributor

@ikavgo ikavgo commented Mar 3, 2025

Proposed Changes

This PR continues and hopefully somewhat completes rabbit_queue_type story. It also addresses Management UI ifs pollution.
I introduce a number of additional callbacks to rabbit_queue_type module. I and Karl entertained this idea of reusing capabilities for some. For xref/dialyzer sake I kept the callbacks.
In principle all tests should pass as is...

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

Note: I see global.js reformatting too much too. To be fixed.

@ikavgo ikavgo requested a review from michaelklishin March 3, 2025 23:05
@ikavgo ikavgo marked this pull request as draft March 3, 2025 23:15
@ikavgo ikavgo force-pushed the ik-allow-queue-as-plugin branch from 37105d5 to d6d729c Compare March 3, 2025 23:17
@kjnilsson kjnilsson self-requested a review March 4, 2025 15:44
@michaelklishin michaelklishin changed the title Allow adding queues via plugins Proposed queue interface extensions Mar 4, 2025
@michaelklishin
Copy link
Collaborator

For 4.1.0, we will add only a handful of these (as one or a few separate PRs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants