Switch is_<queue_type> to using queue.type field in Management UI #13604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikavgo
force-pushed
the
ik-fix-is_type-in-management-ui
branch
4 times, most recently
from
ed1d6a5 to
5d6cd78
Compare
Also, since queue.type field rendered by QueueMod:format and all queues had it hard-coded here, I unhardcode them here to use Type name.
ikavgo
force-pushed
the
ik-fix-is_type-in-management-ui
branch
from
5d6cd78 to
8ae0163
Compare
Contributor
Author
|
@michaelklishin ping |
Collaborator
|
This looks good at first glance. I will give it a shot later today. |
michaelklishin
approved these changes
Mar 25, 2025
michaelklishin
added a commit
that referenced
this pull request
Mar 25, 2025
Switch is_<queue_type> to using queue.type field in Management UI (backport #13604)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-queue-type is not mandatory. Using queue.type is more robust.
See also #13603