Fix crash when consuming from unavailable quorum queue #13625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| condition = ?V_1_0_AMQP_ERROR_INTERNAL_ERROR, | ||
| description = {utf8, Desc}}}}} -> | ||
| ?assertEqual( | ||
| <<"failed consuming from quorum queue 'q-down' in vhost '/': noproc">>, |
Collaborator
There was a problem hiding this comment.
Should we replace the "noproc" with something like "the leader replica was unavailable or not elected"?
Member
Author
There was a problem hiding this comment.
Ideally yes. However, noproc is an exit reason returned from https://www.erlang.org/doc/apps/stdlib/gen_statem.html#call/3. That function can return other exit reasons too. I'd like to avoid parsing and translating any possible exit reason from gen_statem:call/3. The alternative would be to log this Erlang term only in the server and not pass it down to the client app.
FWIW, I removed the noproc from the test expectation.
Prior to this commit, when a client consumed from an unavailable quorum
queue, the following crash occurred:
```
{badmatch,{error,noproc}}
[{rabbit_quorum_queue,consume,3,[{file,\"rabbit_quorum_queue.erl\"},{line,993}]}
```
This commit fixes this bug by returning any error when registering a
quorum queue consumer to rabbit_queue_type.
This commit also refactors errors returned by
rabbit_queue_type:consume/3 to simplify and ensure seperation of
concerns.
For example prior to this commit, the channel did error
formatting specifically for consuming from streams. It's better if
the channel is unaware of what queue type it consumes from and have each
queue type implementation format their own errors.
kjnilsson
approved these changes
Mar 27, 2025
Contributor
kjnilsson
left a comment
kjnilsson
left a comment
There was a problem hiding this comment.
This looks good to me. Just a bit of formatting feedback.
dumbbell
approved these changes
Mar 27, 2025
mergify bot
pushed a commit
that referenced
this pull request
Mar 27, 2025
#13625 (comment) #13625 (comment) (cherry picked from commit c151806)
ansd
added a commit
that referenced
this pull request
Mar 27, 2025
#13625 (comment) #13625 (comment) (cherry picked from commit c151806)
ikavgo
pushed a commit
that referenced
this pull request
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, when a client consumed from an unavailable quorum queue, the following crash occurred:
This commit fixes this bug by returning any error when registering a quorum queue consumer to rabbit_queue_type.
This commit also refactors errors returned by
rabbit_queue_type:consume/3 to simplify and ensure seperation of concerns.
For example prior to this commit, the channel did error formatting specifically for consuming from streams. It's better if the channel is unaware of what queue type it consumes from and have each queue type implementation format their own errors.
Jira: RMQ-1582