Remove log level tests #13723
Merged
Remove log level tests #13723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When debug logging is enabled, we log something at each log level to test if logs are emitted. I don't think this is particularly useful, but it's certainly annoying, because I constatnly need to filter out these logs when searching if any errors happened during tests.
mkuratczyk
force-pushed
the
remove-test-logs
branch
from
52df7f2 to
cd2aa86
Compare
ansd
approved these changes
Apr 11, 2025
Member
ansd
left a comment
ansd
left a comment
There was a problem hiding this comment.
I agree, this fake logging has also annoyed me multiple times.
mergify bot
pushed a commit
that referenced
this pull request
Apr 11, 2025
When debug logging is enabled, we log something at each log level to test if logs are emitted. I don't think this is particularly useful, but it's certainly annoying, because I constatnly need to filter out these logs when searching if any errors happened during tests. (cherry picked from commit 589e0b5)
mkuratczyk
added a commit
that referenced
this pull request
Apr 11, 2025
When debug logging is enabled, we log something at each log level to test if logs are emitted. I don't think this is particularly useful, but it's certainly annoying, because I constatnly need to filter out these logs when searching if any errors happened during tests. (cherry picked from commit 589e0b5) Co-authored-by: Michal Kuratczyk <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Apr 11, 2025
When debug logging is enabled, we log something at each log level to test if logs are emitted. I don't think this is particularly useful, but it's certainly annoying, because I constatnly need to filter out these logs when searching if any errors happened during tests. (cherry picked from commit 589e0b5) Co-authored-by: Michal Kuratczyk <[email protected]> (cherry picked from commit abdcd47)
mkuratczyk
pushed a commit
that referenced
this pull request
Apr 11, 2025
When debug logging is enabled, we log something at each log level to test if logs are emitted. I don't think this is particularly useful, but it's certainly annoying, because I constatnly need to filter out these logs when searching if any errors happened during tests. (cherry picked from commit 589e0b5) Co-authored-by: Michal Kuratczyk <[email protected]> (cherry picked from commit abdcd47) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
michaelklishin
pushed a commit
that referenced
this pull request
Apr 24, 2025
When debug logging is enabled, we log something at each log level to test if logs are emitted. I don't think this is particularly useful, but it's certainly annoying, because I constatnly need to filter out these logs when searching if any errors happened during tests.
ikavgo
pushed a commit
that referenced
this pull request
May 5, 2025
When debug logging is enabled, we log something at each log level to test if logs are emitted. I don't think this is particularly useful, but it's certainly annoying, because I constatnly need to filter out these logs when searching if any errors happened during tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debug logging is enabled, we log something at each log level to test if logs are emitted. I don't think this is particularly useful, but it's certainly annoying, because I constantly need to filter out these logs when searching if any errors happened during tests.